CODEOWNERS: add ajoseph for kernel/manual-config.nix #245137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is hard to get people to test changes to our kernel expression on anything other than x86_64 and aarch64 before merging changes. Therefore, I would like to be notified of PRs opened agains this file, so that I can hopefully catch breakage before it is merged, rather than afterwards.
ghost
requested a review
from 
ofborg
bot
added
10.rebuild-darwin: 0
Ma27
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
It is hard to get people to test changes to our kernel expression on anything other than x86_64 and aarch64 before merging changes.
Therefore, I would like to be notified of PRs opened agains this file, so that I can hopefully catch breakage before it is merged, rather than afterwards.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)